Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed EMMO to be acronym for Elemental Multiperspective Material Ontology #238

Merged
merged 4 commits into from
Sep 28, 2021
Merged

Changed EMMO to be acronym for Elemental Multiperspective Material Ontology #238

merged 4 commits into from
Sep 28, 2021

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented Sep 28, 2021 •
edited by CasperWA
Loading

Closes #230,
EMMO i sno longer acronym for European Materials & Modeling Ontology, but is changed to
Elemental Multiperspective Material Ontology.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

Only a small change in README.md

CasperWA
CasperWA approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this name really never mentioned in any other place in the whole repository? 😮

@CasperWA CasperWA mentioned this pull request Sep 28, 2021
Closed
4 tasks
@francescalb
Copy link
Collaborator Author

Good thing you asked, I found some Europeean :)

@francescalb francescalb changed the title Changed EMMO to be acrobym for Elemental Multiperspective Material Ontology Changed EMMO to be acronym for Elemental Multiperspective Material Ontology Sep 28, 2021
@francescalb francescalb merged commit 44e3a3a into master Sep 28, 2021
@CasperWA CasperWA deleted the flb/close-230-emmoAcronym branch September 28, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA CasperWA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update name of EMMO to Elemental Multiperspective Material Ontology
2 participants
@francescalb @CasperWA